New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install button in version list shows confusing "works with" message #3229

Closed
diox opened this Issue Aug 8, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@diox
Member

diox commented Aug 8, 2016

STR:

Expected results:

  • Since you're using a desktop browser, the install buttons should not say anything about Android. Or maybe you should have been redirected ? Not sure. Anything but the behavior described below :)

Actual results:

  • When hovered, the versions show a green install button with a super confusing warning saying "works in Android" - which is not true - with a "no" red sign.

It looks like it's done by https://github.com/mozilla/addons-server/blob/master/static/js/zamboni/buttons.js ; not sure, lots of duplication between different templates and that js code :(

@vcarciu

This comment has been minimized.

vcarciu commented Sep 6, 2016

Verified as fixed : http://screencast.com/t/y4qwx0zZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment