Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions are not listed in descending order of priority #4101

Closed
vasilicatamas opened this issue Mar 2, 2017 · 4 comments · Fixed by mozilla/addons-server#4881
Closed

Comments

@vasilicatamas
Copy link

Steps to reproduce:

  1. Navigate to https://addons-dev.allizom.org/en-US/firefox/addon/permissionsorder1/
  2. Click on “Permissions” link.

Expected results:
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1339952#c1 the permissions are listed as follows:

  • the hosts permission: because this is probably the most understandable risk. It's related directly to what people use firefox for, browsing.
  • native messaging: because it means you are getting out of the Firefox sandbox.
  • the rest (no order)

Actual results:
Permissions are not listed in descending order of priority.

Additional notes:

  • This issue reproduces on AMO-dev using Firefox 54.0a1 (2017-03-02) under Windows 10 64-bit.
  • This priority order is already applied in installation permission pop-up.
  • Please see the attached screenshots for this issue:
    2017-03-02_1617
    2017-03-02_1618
@eviljeff
Copy link
Member

eviljeff commented Mar 7, 2017

The PRD didn't specify there was an order of priority so...

@vasilicatamas
Copy link
Author

Seems that clipboardRead and clipboardWrite permissions are not displayed in the same order they appear in browser pop-up, The browser displays permissions in the order they are declared in manifest json, excepting hosts and native messaging. Tested using https://addons-dev.allizom.org/en-US/firefox/addon/promptable5/ on Firefox 55.0a1 (2017-03-09):
2017-03-10_1622
2017-03-10_1621

@vasilicatamas vasilicatamas reopened this Mar 10, 2017
@eviljeff
Copy link
Member

There's no particular reason to display them in the manifest order - they are displayed in alphabetical (of the permission name) instead. It would be better if Firefox did that too because that way the ordering is consistent between different add-ons.

@vasilicatamas
Copy link
Author

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1346722 at the suggestion of eviljeff .

Verified fixed on AMO-dev using Firefox 55.0a1 (2017-03-12). Permissions are successfully listed in descending order of priority. Postfix screenshot:
2017-03-13_1246

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants