Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review mails to addon developer doesnt contain the review comment #4605

Closed
tsl143 opened this issue Jul 30, 2017 · 5 comments
Closed

Review mails to addon developer doesnt contain the review comment #4605

tsl143 opened this issue Jul 30, 2017 · 5 comments

Comments

@tsl143
Copy link

tsl143 commented Jul 30, 2017

Describe the problem and steps to reproduce it:

A user reviewed an addon, the mail was sent to addon developer.

What happened?

The mail received was not having the actual review comment

What did you expect to happen?

The mail should have the review comment.

Anything else we should know?

screen shot 2017-07-30 at 9 39 30 am

screen shot 2017-07-30 at 9 39 47 am

@jvillalobos
Copy link

I haven't had this problem before. It's possible that the review was submitted initially without text and later edited. This needs reliable steps to reproduce.

@ValentinaPC
Copy link

I could reproduce the initial issue, if following the suggestion @jvillalobos added above.

STR:

  1. Write an empty review for any add-on while using the new desktop pages i.e. https://addons-dev.allizom.org/en-US/firefox/addon/webext-compat/
  2. Edit the empty review by adding some text
  3. Observe Fake Mails logs - https://addons-internal.dev.mozaws.net/en-US/admin/mail

Results:
Initial review text "None" is not replaced with the new text.

@eviljeff
Copy link
Member

Is the issue more that we don't send a new email if the review text is edited by the user?

@Rob--W
Copy link
Member

Rob--W commented Sep 10, 2017

Most if not all of the review mails that I got over the past few weeks / months don't include the review text, only the rating.

@diox
Copy link
Member

diox commented Nov 15, 2017

#4966 is newer but probably explains the issue, so closing in favor of that one.

@diox diox closed this as completed Nov 15, 2017
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants