Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using middle-click or CTRL+Right-click on the extension card area opens the extension page in a new tab #2072

Open
dceban opened this issue Jun 17, 2019 · 7 comments · Fixed by mozilla/addons-frontend#9096
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@dceban
Copy link

dceban commented Jun 17, 2019

Steps to reproduce:

  1. Open addons.mozilla main page.
  2. Scroll to the "Featured extensions" section (or any section that has addons cards).
  3. Hover over any extension's area (but not its title).
  4. Try to open it in a new tab page using the middle click or CTRL+Click

Actual results:
Extension page opened in the same tab.

Expected results:
Open the extension page in a new tab.

(click where the cursor from the screenshot is located)
firefoxAddonClickCard

┆Issue is synchronized with this Jira Task

@wagnerand wagnerand reopened this Jun 17, 2019
@muffinresearch
Copy link
Contributor

This appears to be due to not using a link around the block level content.

@ioanarusiczki
Copy link

ioanarusiczki commented Feb 7, 2020

@bobsilverberg I verified this on AMO dev with FF72(Win10).

new tab

@bobsilverberg
Copy link
Contributor

We had to back out the change that fixed this as we discovered that it created nested anchor tags. A different solution will need to be devised for this.

@bobsilverberg bobsilverberg reopened this Feb 12, 2020
@bobsilverberg bobsilverberg removed this from the 2020.02.13 milestone Feb 12, 2020
@TheSTL
Copy link

TheSTL commented Feb 12, 2020

hey @bobsilverberg i want to work again on this issue.

@bobsilverberg
Copy link
Contributor

Ok @TheSTL, go ahead. @mirefly made a suggestion about a different approach to this at #13676. I think it's going to be a bit tricky because of the recommended badge, but please feel free to give it a try.

@ioanarusiczki
Copy link

@bobsilverberg I checked on AMO stage - this doesn't look reverted to me.

AMO stage not reverted

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants