Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add-on reducer state more explicit #10708

Closed
kumar303 opened this issue Aug 29, 2017 · 1 comment · Fixed by mozilla/addons-frontend#3073
Closed

Make add-on reducer state more explicit #10708

kumar303 opened this issue Aug 29, 2017 · 1 comment · Fixed by mozilla/addons-frontend#3073
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented Aug 29, 2017

It's really tough to see what properties we actually store in the add-on reducer state. This has led to numerous bugs and has also made it tricky to add new add-on properties.

I'd like to start by restructuring the reducer a bit and getting rid of all spreads, carefully. This will be focused on preparing to solve the following bugs:

For QA: please test for regressions in AMO and the Discovery Pane for anything related to installing add-ons and themes.

@willdurand
Copy link
Member

I was feeling the same when thinking about new features to add. Semi-related, I have converted the addon code into a ducks module: https://github.com/willdurand/addons-frontend/commit/933f81cfd86ece933e6149186fe4a2f168c6b609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants