Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the 'More extensions by …' card should show a red alert wherever an add-on will be incompatible with Firefox Quantum #11140

Closed
grahamperrin opened this issue Nov 8, 2017 · 1 comment

Comments

@grahamperrin
Copy link

Issue

For users of ESR 52.x and 56.x, in some cases the card shows a mixture of legacy and non-legacy add-ons:

  • with no hint of incompatibility with Firefox Quantum.

Example

2017-11-07 02 24 31 56 0 2 user-agent switcher sdk - add-ons for firefox

Image source: https://addons.mozilla.org/addon/user-agent-switcher-firefox/ viewed with 56.0.2 on FreeBSD-CURRENT.

Enhancement request

Show an alert. Currently used in other situations:

  • a red 'no entry' icon.

Show the alert – that small icon – without requiring the user to point or hover.

If the add-on will require a restart: no need to also show the yellow alert – an overarching single red alert should suffice.

Suggested milestone

Related

"More extensions by author_name" section has layout issues · Issue mozilla/addons#10901 · mozilla/addons-frontend

  • not yet milestoned (and I don't imagine any urgency).

Background

From mozilla/addons-frontend#3807 (comment) (2017-11-06) under Not compatible with Firefox Quantum by willdurand · Pull Request …:

… It'll be nice to also have the icon in listings e.g. as shown in the shots at #11108

A little later:

I'm in two minds about that. One mind:

  • discourage unnecessary clicks.

Second mind:

  • serendipitous discovery of 'More extensions by …' the same developer

– and the more can be a very good thing, and 👍 it is already disclosed (without a Show more click) in the primary page for an add-on.


Unless I'm missing something (I'm speeding through screenshots, not code), we do not yet have:

  • the no entry icon (Not compatible with Firefox Quantum) in the More extensions by … area:

@jvillalobos
Copy link

jvillalobos commented Nov 8, 2017

I don't think we should be showing the "not compatible" messaging beyond the listing pages. In a couple of weeks most users will either be using Quantum (in which case they will only see Quantum-compatible add-ons on AMO) or ESR (in which case they will probably stick with ESR and legacy add-ons for the next ~8 months). This clutters the UI and gives little benefit to users, who can click through and see the warning in the listing page anyway.

@KevinMind KevinMind added migration:no-jira repository:addons-frontend Issue relating to addons-frontend labels May 5, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants