-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfill request animation in the test suite #11248
Comments
Good call, thanks for noticing. The tests since moving to Jest have been so noisy that I run them with the --silent argument most of the time, so I missed this entirely. 😓
|
Why would the reducers yield such warnings though? 🤔 |
Yeah, when I get time I'm going to create a console reporter plugin to accomplish this: jestjs/jest#4156 |
This depends on a new polyfill module introduced by mozilla/addons-frontend#4119 I'll fix this when that patch lands. |
A few of the tests in mozilla/addons-frontend#4182 kept failing with out of memory errors. I guess the Travis VM doesn't perform well with the polyfill. Instead of spending a lot of time investigating I'm just going to close this for now. Maybe there's another way to make the React warnings go away. |
We load a polyfill in the web application for React 16 (search for
import 'raf/polyfill'
) but not in the test suite. This litters the console with warnings. We should add that polyfill to the test suite, maybe intests/setup.js
.The text was updated successfully, but these errors were encountered: