Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill request animation in the test suite #11248

Closed
kumar303 opened this issue Nov 30, 2017 · 5 comments
Closed

Polyfill request animation in the test suite #11248

kumar303 opened this issue Nov 30, 2017 · 5 comments
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

We load a polyfill in the web application for React 16 (search for import 'raf/polyfill') but not in the test suite. This litters the console with warnings. We should add that polyfill to the test suite, maybe in tests/setup.js.

screenshot 2017-11-30 16 53 16

@tofumatt
Copy link
Contributor

tofumatt commented Dec 1, 2017 via email

@willdurand
Copy link
Member

Why would the reducers yield such warnings though? 🤔

@kumar303
Copy link
Contributor Author

kumar303 commented Dec 1, 2017

The tests since moving to Jest have been so noisy...

Yeah, when I get time I'm going to create a console reporter plugin to accomplish this: jestjs/jest#4156

@kumar303
Copy link
Contributor Author

This depends on a new polyfill module introduced by mozilla/addons-frontend#4119

I'll fix this when that patch lands.

@kumar303
Copy link
Contributor Author

A few of the tests in mozilla/addons-frontend#4182 kept failing with out of memory errors. I guess the Travis VM doesn't perform well with the polyfill. Instead of spending a lot of time investigating I'm just going to close this for now. Maybe there's another way to make the React warnings go away.

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants