Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-cookie for reliable cookie state #12611

Closed
kumar303 opened this issue Oct 31, 2018 · 6 comments · Fixed by mozilla/addons-frontend#6825
Closed

Upgrade react-cookie for reliable cookie state #12611

kumar303 opened this issue Oct 31, 2018 · 6 comments · Fixed by mozilla/addons-frontend#6825
Assignees
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented Oct 31, 2018

For QA: please check for regressions in any feature that relies on a cookie:


We need to upgrade react-cookie for better SSR support. See #12461 for details on how the older library is likely creating bugs.

@willdurand willdurand added the priority:p2 Issues at this level should be fixed within the next few releases. label Oct 31, 2018
@willdurand
Copy link
Member

Raised to p2 because that seems like something we want sooner than later.

@kumar303
Copy link
Contributor Author

Yeah, good point. We should probably do this before rolling out any new experiments.

@willdurand
Copy link
Member

Upgrading was straightforward but Enzyme does not support the React Context API (not fully, not with shallow), which breaks some test cases...

@willdurand
Copy link
Member

@willdurand
Copy link
Member

Upgrading was straightforward but Enzyme does not support the React Context API (not fully, not with shallow), which breaks some test cases...

I found a nice workaround and filed: #12625 to remove it once Enzyme supports the Context API.

@ioanarusiczki
Copy link

  • log in / log out I tested with multiple accounts on AMO dev and AMO stage. I could log in and log out without issues.
  • The A/B test was re-tested on AMO Stage and results are here
  • after switching to view classic desktop then back to the new front end there's the mamo cookie's value is "on"

Cookies on AMO stage
cookies

Verified on AMO dev and AMO stage with FF63 - Win10

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants