Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: send enforcement action to cinder api when notifying about a decision #14778

Closed
1 task done
eviljeff opened this issue May 8, 2024 · 9 comments · Fixed by mozilla/addons-server#22233
Closed
1 task done
Assignees
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented May 8, 2024

Description

resolves https://mozilla-hub.atlassian.net/browse/AMO2-592

Currently, decisions taken by AMO internal review tool are sent to Cinder via create_decision API call.
Cinder has updated this call to accept enforcement_action_slugs in addition to policy_uuids. See new docs. So we can now independently specify the Enforcement Actions in a decision. This is needed for Transparency Reporting purposes.

Acceptance Criteria

### Acceptance Criteria
- [x] api call to cinder includes `enforcement_action` too.
- [x] add amo-reject-version-addon (and -warning variant) actions to cinder stage
- [x] add amo-reject-version-addon (and -warning variant) actions to cinder prod### Checks
  • If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

I think I should look around reported extensions or themes that are reviewed from AMO.
Probably the same for #14779 ?

@eviljeff
Copy link
Member Author

For this issue:

I'll comment in #14779

@ioanarusiczki
Copy link

Still looking around, I finally have the expected results but I don't know why I didn't get this for my first 2 tests.

reject for an extension https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630843/decisions?filters=%7B%7D
reject for an escalated theme https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630844/decisions?filters=%7B%7D

@eviljeff
Copy link
Member Author

@ioanarusiczki not all the policies are set/linked up on dev/stage, but that's not a new problem. That the enforcement action is sent is this issue.

@ioanarusiczki
Copy link

Yeah I tried again for an extension , reporting it for add-on policies with location inside the add-on so it's flagged for rev tools then I rejected a version, also tried disabling it and I see the actions in the Decision tab

https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630845/decisions?filters=%7B%7D

I have 2 ids which didn't get the information
https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630841/decisions?filters=%7B%7D
https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630842/decisions?filters=%7B%7D
and I've no idea why yet, I remember assigning the job from the infringement queue but not sure that would have to do with anything.

@ioanarusiczki
Copy link

I get the Enforcement Action in Decisions tab now for reject "AMO Reject Version (Addon)", disable "AMO Disable Addon" and clear human review as "AMO Approve" (used when reporter is notified that the content won't be disabled) https://stage.cinder.nonprod.webservices.mozgcp.net/investigate/amo_addon/630846/decisions?filters=%7B%7D

Force-enable and Approve actions from rev tools are not present here. Not sure if it's expected so let me know if you need a followup.

@eviljeff
Copy link
Member Author

@ioanarusiczki force-enable and approve actions should be present too - can you file a follow-up?

@eviljeff
Copy link
Member Author

eviljeff commented May 15, 2024

@ioanarusiczki force-enable and approve actions should be present too - can you file a follow-up?

fwiw, I think sentry bot already picked this up as https://mozilla.sentry.io/issues/5348822972/

@ioanarusiczki
Copy link

@eviljeff I've no access to sentry but I filed it #14788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants