Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Run CI on branches too #14876

Open
1 task
eviljeff opened this issue Jun 20, 2024 · 1 comment
Open
1 task

[Task]: Run CI on branches too #14876

eviljeff opened this issue Jun 20, 2024 · 1 comment
Labels
repository:addons-server Issue relating to addons-server

Comments

@eviljeff
Copy link
Member

eviljeff commented Jun 20, 2024

Description

With our previous circleci set-up, CI was triggered on pushes to any branch - not just master - in addition to PRs being created. With the current github actions implementation, CI is triggered on only pushes to master, in addition to PRs.

Acceptance Criteria

Acceptance Criteria

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

@eviljeff eviljeff added needs:info repository:addons-server Issue relating to addons-server labels Jun 20, 2024
@KevinMind
Copy link
Contributor

Related attempt: mozilla/addons-server#22412 trying to replace pull_request with push. Problem with this is that push only registers push to origin. So

fork, push: runs only on fork
fork,pull_request: runs on addons server

There is no relationship between these two workflow runs.

It's kind of hard to explain but it might end up either not having CI related to PRs from forks, or having duplicate jobs for PRs from forks. We need to thoroughly test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

3 participants