Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to node 4.x LTS for addons-linter integration. #2588

Closed
muffinresearch opened this issue Mar 1, 2016 · 8 comments
Closed

Move to node 4.x LTS for addons-linter integration. #2588

muffinresearch opened this issue Mar 1, 2016 · 8 comments
Assignees
Labels
repository:addons-server Issue relating to addons-server

Comments

@muffinresearch
Copy link
Contributor

Since we're looking to use node 4.x and above for the addons-frontend it might make sense to update the node version we're proposing to use for the linter.

/cc @EnTeQuAk

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Mar 1, 2016

Let's cc @jasonthomas on this so he can start working on packaging up node 4.x for our servers. Should we open a bugzilla ticket separately for this?

@muffinresearch
Copy link
Contributor Author

Yeah you'll want an ops bug in bugzilla for that.

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Mar 1, 2016

Does the linter theoretically work on 4.x already or is there more work needed?

@jasonthomas
Copy link
Member

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Mar 1, 2016

I don't have access to that repo but that's awesome then. Since I can't see the link, can you give me the correct mirror? Our current mirror is:

baseurl=https://s3-us-west-2.amazonaws.com/net-mozaws-prod-us-west-2-ops-rpmrepo-mirror/nodesource/0.12/7/x86_64/

Same mirror but only 4.x instead of 0.12?

@jasonthomas
Copy link
Member

Yes, replacing 0.12 with 4.x should work.

@EnTeQuAk EnTeQuAk self-assigned this Mar 2, 2016
@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Mar 8, 2016

Supports mozilla/addons-linter#62

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Mar 8, 2016

added https://bugzilla.mozilla.org/show_bug.cgi?id=1254553 to upgrade nodejs on dev, stage and prod

EnTeQuAk referenced this issue in mozilla/addons-server Mar 9, 2016
Upgrade to nodejs 4.x, fixes #1799
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

5 participants