-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editor tools to handle unlisted and listed versions #3754
Comments
I guess we could hide the unlisted versions from the normal reviewers and pretend they don't exist but for unlisted reviews and staff it's going to get tricky. |
@wagnerand suggested separate review pages or separate tabs on the same page. (the former is easier to implement) |
Using different pages makes sense to me. |
@jvillalobos what should the behaviour be if there are no listed or no listed versions and you attempt to access the unlisted or listed review page? (i.e. you access /review and it only has unlisted versions, or visa versa). If you are staff/admin should it:
If a normal reviewer accesses the /review page and the add-on only has unlisted versions should it:
|
I think no versions in the first case, 404 in the second. @wagnerand, thoughts? |
👍 |
Part of #3477
Currently we have a single review page that shows all (non-beta) versions of an add-on and allows messages/feedback to be sent, and actions to be taken, on the latest version of the add-on. Access is gated on Addon.is_listed. With unlisted and listed versions on the same add-on we need to make some changes.
The text was updated successfully, but these errors were encountered: