Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor tools to handle unlisted and listed versions #3754

Closed
eviljeff opened this issue Nov 11, 2016 · 6 comments · Fixed by mozilla/addons-server#4048
Closed

Update editor tools to handle unlisted and listed versions #3754

eviljeff opened this issue Nov 11, 2016 · 6 comments · Fixed by mozilla/addons-server#4048
Assignees
Labels
repository:addons-server Issue relating to addons-server
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Nov 11, 2016

Part of #3477
Currently we have a single review page that shows all (non-beta) versions of an add-on and allows messages/feedback to be sent, and actions to be taken, on the latest version of the add-on. Access is gated on Addon.is_listed. With unlisted and listed versions on the same add-on we need to make some changes.

@eviljeff
Copy link
Member Author

eviljeff commented Nov 11, 2016

I guess we could hide the unlisted versions from the normal reviewers and pretend they don't exist but for unlisted reviews and staff it's going to get tricky.
Should we show all the versions in the review history? Sending any messages, etc, are usually linked to the latest version... which would be which? the last listed version? the last version from either channel?

@eviljeff
Copy link
Member Author

@wagnerand suggested separate review pages or separate tabs on the same page. (the former is easier to implement)

@jvillalobos
Copy link

Using different pages makes sense to me.

@eviljeff
Copy link
Member Author

eviljeff commented Nov 21, 2016

@jvillalobos what should the behaviour be if there are no listed or no listed versions and you attempt to access the unlisted or listed review page? (i.e. you access /review and it only has unlisted versions, or visa versa). If you are staff/admin should it:

  • 404?
  • Show a review page but with no versions?
  • redirect to the review page for the channel where there are versions?

If a normal reviewer accesses the /review page and the add-on only has unlisted versions should it:

  • 404?
  • Show a review page but with no versions?

@jvillalobos
Copy link

I think no versions in the first case, 404 in the second. @wagnerand, thoughts?

@wagnerand
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants