Same permission are shown twice

[gloomy-ghost]

Describe the problem and steps to reproduce it:

Go to https://addons.mozilla.org/en-US/firefox/addon/disqus-undirect/
Click "Permissions"

What happened?

Two permissions are the same

What did you expect to happen?

There should only be one permission

[andymckay]

/cc @eviljeff

[eviljeff]

Yeah we don't do any de-duping at the moment and *://disqus.com/* is in both permissions and content_scripts.

[wagnerand]

Mentor: @eviljeff

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

[apoorvaeternity]

@eviljeff
I am new to open source.
Where should I look to fix this issue?
I mean what files do I have to modify.

[eviljeff]

@apoorvaeternity There are a few ways to solve this, but the simplest, (I think), that doesn't require lots of changes and re-parsing existing manifests is to change https://github.com/mozilla/addons-server/blob/master/src/olympia/files/models.py#L434:L435 so duplicates are filtered out.

Then it will need a test to prove it works. One very similar to https://github.com/mozilla/addons-server/blob/master/src/olympia/files/tests/test_models.py#L312 but with some duplicates. You could probably just add some duplicates into the permissions list in that test, actually.

[apoorvaeternity]

@eviljeff Okay I am working on it.

[apoorvaeternity]

@eviljeff I have made a pull request.
If it gets accepted it will be my first contribution to open source.

[vcarciu]

Verified as fixed on -dev :