Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted theme submissions are not signed through the new auto-approval flow #7125

Closed
AlexandraMoga opened this issue Nov 18, 2019 · 2 comments · Fixed by mozilla/addons-server#12899

Comments

@AlexandraMoga
Copy link

Follow up for #7047

Describe the problem and steps to reproduce it:

  1. Log in to AMO -dev
  2. Submit a new unlisted theme (package or wizard)
  3. Wait for it to be approved/signed

What happened?

The theme is not signed

What did you expect to happen?

Theme is signed after a short while

Anything else we should know?

@diox

  • these might happen because we do not have an auto-approval workflow for themes (?)
  • I've checked with stage and unlisted themes are being signed through the old process

Example of un-signed unlisted theme:
https://addons-dev.allizom.org/en-US/developers/addon/47e5641ef28f4322a95d/versions/1689761

@diox
Copy link
Member

diox commented Nov 19, 2019

Yeah forgot that unlisted themes were a thing...

@AlexandraMoga
Copy link
Author

Verified fixed on stage. Unlisted themes are now signed in a short while after submission. Listed themes are still going through the normal manual approval flow.

Example of a theme with both unlisted (approved) and listed (awaiting review) versions:
https://addons.allizom.org/en-US/developers/addon/mixed-version-theme/versions

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants