New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to filter by author in language tools API #730
Comments
I was hoping to avoid that, it makes the query worse... I guess we still have heavy caching to save us... |
I'm sorry to hear it causes issues. Are language tools APIs used anywhere else? If not, maybe we could just limited them to Mozilla RelEng provided addons? |
We have no good way of identifying the add-ons besides the author (IIRC their However with the caching it's probably not entirely terrible, there will be a slight performance loss on cold cache but it should be bearable. I'll look into it and implement what's less worse :) |
Thank you! |
Fix will land on dev shortly and be in next week's tag. It adds support for passing |
Verified on -dev by sending the following request:
I've looked at some of the results and in all cases Mozilla was listed as author or one of the authors. |
This it the last known issue blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1429610
We need to filter langpacks/dictionaries to only include ones provided by Mozilla RelEng Team when selecting ones to show in Preferences.
aswan says that he's not very opinionated on how to do that - we can probably add an author ID to the query, or get list with authors and filter by it, either should work fine for us.
The text was updated successfully, but these errors were encountered: