Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CinderJob.DECISION_ACTIONS into /constants/ #9492

Closed
eviljeff opened this issue Feb 29, 2024 · 1 comment · Fixed by mozilla/addons-server#21973
Closed

refactor CinderJob.DECISION_ACTIONS into /constants/ #9492

eviljeff opened this issue Feb 29, 2024 · 1 comment · Fixed by mozilla/addons-server#21973
Assignees
@eviljeff
Labels
component:abuse_reports

Comments

@eviljeff
Copy link
Member

eviljeff commented Feb 29, 2024 •
edited by data-sync-user
Loading

We define the possible values of CinderJob.decision_action in CinderJob.DECISION_ACTIONS but also reference it widely elsewhere. If we refactor to move the definition out of the model it will be easier to use - including in other constants (e.g. the activity constants, where we are defining cinder_action as a string currently)

┆Issue is synchronized with this Jira Task
@eviljeff eviljeff self-assigned this Mar 4, 2024
@eviljeff eviljeff mentioned this issue Mar 5, 2024
Merged
@KevinMind
Copy link
Contributor

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-742

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eviljeff eviljeff

Labels
component:abuse_reports
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move DECISION_ACTIONS to constants eviljeff/olympia
2 participants
@eviljeff @KevinMind