Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request : Support 301 redirects on API endpoints #25

Open
dovy opened this issue Feb 7, 2017 · 3 comments
Open

Feature request : Support 301 redirects on API endpoints #25

dovy opened this issue Feb 7, 2017 · 3 comments
Labels
enhancement New feature or request

Comments

@dovy
Copy link

dovy commented Feb 7, 2017

I want to love this library, but I have an API that I'm trying to extend a class for this. It SHOULD be working, but it's stuck in a 301 response and nothing continues. How can I get redirects to be handled? It looks like they're stuck...
@jpaugh
Copy link
Contributor

jpaugh commented Feb 8, 2017 •
edited
Loading

I did not consider redirects when designing the library. Sorry about that!

Detecting and following redirects is probably not hard, since the http requests all happen in a single spot. If you have time to do it, send a pull request.

@gene1wood
Copy link
Contributor

We're thinking of migrating to using requests instead of httplib in which case this will be a simple change.

@gene1wood gene1wood changed the title 301 response, *sigh* Feature request : Support 301 redirects on API endpoints Apr 13, 2018
@gene1wood gene1wood added the enhancement New feature or request label Apr 13, 2018
@dovy
Copy link
Author

dovy commented Apr 13, 2018

Yea... Requests has a ton more power to it. I strongly suggest it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dovy @gene1wood @jpaugh