immutable IncompleteRequest.__getattr__ #75
Conversation
|
@mattsb42 Thank you for the PR! How would you propose going about introducing this breaking change (so as to avoid folks getting the new version and it breaking existing codebases? |
|
This is a good question, and IMO really depends on your plans for the project. It looks like there's been a bunch of recent movement here, I'm guessing with Mozilla taking over the project? Maybe #39 would be an opportune time to make some significant changes? The reason I think this is important is that the current structure makes it very difficult to pass around and use any partial constructions. You have to end up doing silly things like this[1] to avoid continuously messing up the url. Another possible option for accomplishing this without breaking backwards compatibility would be to let the user pass an option on instantiation that would determine whether or not this should be a mutable or immutable client. That would increase the API complexity, but would let the user choose this behavior if they want it, and leave the default behavior as-is. |
The main discussion of the problem is in #74, but TLDR is that
IncompleteRequest.__getattr__mutating and returningselfmakes a lot of use-cases needlessly complicated.This is a breaking change.
fixes: #74
I also fixed
setup.pyto actually work with thetoxconfig. It looks like that used to be there but got rolled back as part of an unrelated set of changes.