Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report basic usage and quality metrics for history storage #2299

Closed
data-sync-user opened this issue Nov 29, 2019 · 1 comment · Fixed by #2431
Closed

Report basic usage and quality metrics for history storage #2299

data-sync-user opened this issue Nov 29, 2019 · 1 comment · Fixed by #2431
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Nov 29, 2019

Like the ones we're adding for the logins store, but hopefully quicker to implement because we know how to do it this time.

┆Issue is synchronized with this Jira Task
┆Story Points: 3
┆Epic: Fenix Migration
┆Sprint: SYNC - end 2020-01-17

@data-sync-user data-sync-user changed the title Emit basic quality/perf metrics for history storage Emit basic usage and quality metrics for history storage Dec 5, 2019
@rfk
Copy link
Contributor

rfk commented Dec 20, 2019

OK, so I'm going to try to add slightly more details to this issue :-)

This is basically the history equivalent of this PR for the logins component - we want to instrument and gather a set of basic usage and quality metrics so that we can have some confidence that our bookmarks component is working as intended in the wild.

I left a big long comment on the specifics over in the equivalent bookmarks issue: #2300 (comment)

The only thing that might change for this bug, is the set of metrics that we want to gather. My strawman proposal is actually the same set of metrics as proposed for bookmarks:

  • A readQueryCount and readQueryErrorCount from which we can calculate error rate of read operations.
  • A writeQueryCount and writeQueryErrorCount from which we can calculate error rate of write operations.
  • A readQueryTime timing distribution that measures the execution time of read queries that should be, for want of a better word, "small".
  • A scanQueryTime timing distribution that measures the execution time of read queries that we expect to be costly (getVisitInfos perhaps?).
  • A writeQueryTime timing distribution that measures the execution time of write queries.

In fact, I think I'm open to the suggestion that we should emit a single set of "places metrics" rather than distinct sets of metrics for bookmarks and history. @linacambridge what do you think?

@data-sync-user data-sync-user changed the title Emit basic usage and quality metrics for history storage Report basic usage and quality metrics for history storage Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants