Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose session token migration methods to Swift FxAccountManager #2435

Closed
eoger opened this issue Jan 6, 2020 · 3 comments · Fixed by #2637
Closed

Expose session token migration methods to Swift FxAccountManager #2435

eoger opened this issue Jan 6, 2020 · 3 comments · Fixed by #2637
Assignees

Comments

@eoger
Copy link
Contributor

eoger commented Jan 6, 2020

Firefox for iOS issue

This more or less will be creating bindings for
migrate_from_session_token
in Swift and calling it from the account manager.

┆Issue is synchronized with this Jira Task
┆Story Points: 5
┆Epic: FxA for Firefox iOS
┆Sprint: SYNC - end 2020-02-28

@data-sync-user data-sync-user changed the title Session token migration for Firefox iOS Expose session token migration methods to Swift FxAccountManager Jan 22, 2020
@eoger
Copy link
Contributor Author

eoger commented Jan 23, 2020

@lougeniaC64 if you are interested in doing a bit of Rust + Swift this could be a good first bug, let me know and I'll post more detailed instructions.

@lougeniaC64
Copy link
Contributor

@eoger I'm definitely interested, but I'll probably be picking up some remerge tickets before I get to this FYI. Thanks!

@eoger
Copy link
Contributor Author

eoger commented Jan 29, 2020

The work to do for whoever takes this:

  • Grow in FxAccountManager a migrateFromSessionToken method (feel free to find a better name).
  • This method should takes sessionToken, kSync and kXCS as arguments and calls fxa_migrate_from_session_token.
  • Note that we will not copy the session token.
  • An event migrationComplete should be added to the Event enum, and a transition .NotAuthenticated -> .AuthenticatedNoProfile via migrationComplete should be implemented that does more or less what android components does.
    We should also do whatever Add offline use case for 'migrateFromSessionToken' #2492 ends up doing because we might end-up with the same offline problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants