Exclude download, redirects, reload, embed and framed link visit types from the get_top_frecent_site_infos query

[gabrielluong]

In implementing top frecent sites for Fenix mozilla-mobile/fenix#10342 and mozilla-mobile/android-components#7978, we encountered cases where we would get redirects as part of the results from get_top_frecent_site_infos

application-services/components/places/src/storage/history.rs

Line 1197 in 673e700

pub fn get_top_frecent_site_infos(db: &PlacesDb, num_items: i32) -> Result<TopFrecentSiteInfos> {

In order to avoid that, we can add a exclude_types similar to get_visit_infos in

application-services/components/places/src/storage/history.rs

Line 1218 in 673e700

exclude_types: VisitTransitionSet,

┆Issue is synchronized with this Jira Task
┆Sprint: Backlog

[mhammond]

Do we really need it as a param? I don't really object to it being a param, but I can't see a use-case for the value of that param ever changing, and we could consider adding it as a param once we find the first use-case for needing it to be specified?

[gabrielluong]

Do we really need it as a param? I don't really object to it being a param, but I can't see a use-case for the value of that param ever changing, and we could consider adding it as a param once we find the first use-case for needing it to be specified?

I think that sounds reasonable to hard code the exclusion type into the query. Right now, we're looking at the visited pages that are listed in the "History" screen in Fenix. This is the current exclusion types we're looking to pass in
https://github.com/mozilla-mobile/fenix/blob/8d1bd10e6b00d270cfde13719fa91a8d8f6da7a3/app/src/main/java/org/mozilla/fenix/components/history/PagedHistoryProvider.kt#L36.