Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore incoming sync records for devices we don't know about. #5199

Closed
mhammond opened this issue Oct 21, 2022 · 2 comments
Closed

Ignore incoming sync records for devices we don't know about. #5199

mhammond opened this issue Oct 21, 2022 · 2 comments

Comments

@mhammond
Copy link
Member

mhammond commented Oct 21, 2022

This bit us in desktop - it would have bitten us much less if this was fixed.

If we don't know the device we should ignore the record - so this branch changes to, say a log::warn about not storing, then a continue to ignore the record.

┆Issue is synchronized with this Jira Task

@mhammond
Copy link
Member Author

Turns out we can't actually do this because stand alone syncing (ie, store.sync()) doesn't allow us to pass the device list in, so we'd get no rows! :( I'm mildly surprised iOS tab syncing doesn't seem to be bitten by this, which I suspect is going to come back and bite us moving iOS to the sync manager.

(I'm keeping it open because I think we should still do this once we kill stand-alone syncing)

@mhammond
Copy link
Member Author

I think we already did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants