Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Add a test that opens and closes browser windows (as opposed to tabs) #125

Open
staktrace opened this issue May 9, 2016 · 1 comment
Open

Comments

@staktrace
Copy link
Contributor

We had a leak recently (bug 1264161) where every time a browser window was opened and closed it would leak a bunch of stuff. Surprisingly (to me) none of our automation tests for this, since leak checking is done at shutdown which was too late for this particular scenario. AWSY however would have caught this sort of a leak if it opened and closed windows in addition to tabs. Something to consider adding, and I imagine it shouldn't be too hard. It could be as simple as an extra phase at the end of the test (after "After TP5, tabs closed [+30s, forced GC]") where we cycle through the TP5 set opening and closing each page in a new window, then do a force GC and grab another snapshot. I strongly suspect that such a test would have showed the leak.

@staktrace
Copy link
Contributor Author

https://bugzilla.mozilla.org/show_bug.cgi?id=1277358 is another bug that we can probably test for in AWSY.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant