Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Just display the past year's results by default #129

Open
EricRahm opened this issue Aug 8, 2016 · 3 comments
Open

Just display the past year's results by default #129

EricRahm opened this issue Aug 8, 2016 · 3 comments

Comments

@EricRahm
Copy link
Contributor

EricRahm commented Aug 8, 2016

@nnethercote requested that we only show the past years results by default. This does seem like a more relevant view.

@EricRahm
Copy link
Contributor Author

EricRahm commented Aug 8, 2016

We might need to update merge_graph_json.py to limit to a year, or perhaps add a different mechanism. It's possible we could do this entirely on the web side but honestly that code is a bit of a mystery to me.

@Nephyrin
Copy link
Contributor

Nephyrin commented Aug 9, 2016

The initial zoom range is in the plot constructor, where it defaults to the full data range [1]. The range is just a pair of [startTimestamp, stopTimestamp] iirc. Additionally, the zoom out button calls SetZoomRange with no parameters, which also defaults to the full datarange [2].

I would change both of these spots to use some gDefaultRange value instead of the full datarange, then add a ?fullhistory=1 override in case you want to see older data (or some magic like shift-clicking the zoom-out button).

[1]

this.zoomRange = this.dataRange;

[2]
range = this.dataRange;

@Nephyrin
Copy link
Contributor

Nephyrin commented Aug 9, 2016

change both of these spots to use some gDefaultRange value instead

... Or, more usefully, [gDefaultRangeStart, datarange[1]] to keep using the end of the current data, but overriding the start.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants