Skip to content

Commit

Permalink
Added transparencyCert, SCT1, SCT2 to tests and jsonschemas, added le…
Browse files Browse the repository at this point in the history
…ngth requirement for proof
  • Loading branch information
BrandonTang committed Aug 1, 2017
1 parent d6b00c1 commit a032d8a
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
13 changes: 13 additions & 0 deletions auslib/blobs/schemas/apprelease-v8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,15 @@
backgroundInterval:
type: number
description: This decides how quickly or slowly Firefox downloads an MAR.
transparencyCert:
type: string
description: Certificate recieved from script worker used to submit to CT.
SCT1:
type: string
description: Signed certificate timestamp response when valid certificate is submitted to log.
SCT2:
type: string
description: Signed certificate timestamp response when valid certificate is submitted to log.
# Top level fileUrls are useful primarily for release style builds,
# where the URLs are predictable and only vary by locale and platform.
# It"s worth noting that while we normally serve different channels
Expand Down Expand Up @@ -180,6 +189,8 @@
proof:
type: string
description: The inclusion proof required for binary transparency test.
minLength: 1
maxLength: 834
from:
type: string
description: The release this partial update can be applied to. Should match another release in Balrog"s database.
Expand Down Expand Up @@ -214,6 +225,8 @@
proof:
type: string
description: The inclusion proof required for binary transparency test.
minLength: 1
maxLength: 834
from:
type: string
description: The release this partial update can be applied to. Should match another release in Balrog"s database.
Expand Down
9 changes: 8 additions & 1 deletion auslib/test/blobs/test_apprelease.py
Original file line number Diff line number Diff line change
Expand Up @@ -2924,6 +2924,9 @@ def setUp(self):
"showNeverForVersion": true,
"promptWaitTime": 12345,
"backgroundInterval": 123,
"transparencyCert": "cert",
"SCT1": "sct1",
"SCT2": "sct2",
"fileUrls": {
"c1": {
"partials": {
Expand Down Expand Up @@ -2990,6 +2993,9 @@ def testGetPartialReleaseReferences_Happy_Case(self):
"showNeverForVersion": true,
"promptWaitTime": 12345,
"backgroundInterval": 123,
"transparencyCert": "cert",
"SCT1": "sct1",
"SCT2": "sct2",
"fileUrls": {
"c1": {
"partials": {
Expand Down Expand Up @@ -3059,7 +3065,8 @@ def testSchema8OptionalAttributes(self):
expected_header = '<update type="minor" displayVersion="31.0" appVersion="31.0" platformVersion="None" ' \
'buildID="50" detailsURL="http://example.org/details/l" showPrompt="false" showNeverForVersion="true" ' \
'actions="silent" openURL="http://example.org/url/l" notificationURL="http://example.org/notification/l" ' \
'alertURL="http://example.org/alert/l" promptWaitTime="12345" backgroundInterval="123">'
'alertURL="http://example.org/alert/l" promptWaitTime="12345" backgroundInterval="123" ' \
'transparencyCert="cert" SCT1="sct1" SCT2="sct2">'
expected = ["""
<patch type="complete" URL="http://a.com/complete.mar" hashFunction="sha512" hashValue="41" size="40" proof="foobar"/>
""", """
Expand Down

0 comments on commit a032d8a

Please sign in to comment.