Don't return from from Blob.validate, and pick up latest UI.

auslib/blobs/base.py

@@ -76,8 +76,6 @@ def validate(self):
         errors = [e.message for e in validator.iter_errors(self)]
         if errors:
             raise BlobValidationError("Invalid blob! See 'errors' for details.", errors)
-        else:
-            return True
 
     def getSchema(self):
         def loadSchema():

auslib/test/blobs/test_apprelease.py

@@ -166,7 +166,8 @@ def setUp(self):
 }""")
 
     def testIsValid(self):
-        self.assertTrue(self.blob.validate())
+        # Raises on error
+        self.blob.validate()
 
     def test2_0(self):
         updateQuery = {
@@ -510,8 +511,9 @@ def setUp(self):
 """)
 
     def testIsValid(self):
-        self.assertTrue(self.blobJ2.validate())
-        self.assertTrue(self.blobK.validate())
+        # Raises on error
+        self.blobJ2.validate()
+        self.blobK.validate()
 
     def testSchema2CompleteOnly(self):
         updateQuery = {
@@ -665,7 +667,8 @@ def setUp(self):
 """)
 
     def testIsValid(self):
-        self.assertTrue(self.blobJ2.validate())
+        # Raises on error
+        self.blobJ2.validate()
 
     def testCompleteOnly(self):
         updateQuery = {
@@ -888,8 +891,9 @@ def setUp(self):
 """)
 
     def testIsValid(self):
-        self.assertTrue(self.blobF3.validate())
-        self.assertTrue(self.blobG2.validate())
+        # Raises on error
+        self.blobF3.validate()
+        self.blobG2.validate()
 
     def testSchema3MultipleUpdates(self):
         updateQuery = {
@@ -1118,7 +1122,8 @@ def setUp(self):
 """)
 
     def testIsValid(self):
-        self.assertTrue(self.blobH2.validate())
+        # Raises on error
+        self.blobH2.validate()
 
     def testSchema4WithPartials(self):
         updateQuery = {
@@ -1258,7 +1263,8 @@ def testConvertFromV3(self):
 """)
 
         v4Blob = ReleaseBlobV4.fromV3(v3Blob)
-        self.assertTrue(v4Blob.validate())
+        # Raises on error
+        v4Blob.validate()
 
         expected = {
             "name": "g2",
@@ -1324,7 +1330,8 @@ def testConvertFromV3Noop(self):
 """)
 
         v4Blob = ReleaseBlobV4.fromV3(v3Blob)
-        self.assertTrue(v4Blob.validate())
+        # Raises on error
+        v4Blob.validate()
 
         expected = v3Blob.copy()
         expected["schema_version"] = 4

auslib/test/blobs/test_settings.py

@@ -23,7 +23,7 @@ class TestSchemaSettings(unittest.TestCase):
     def test_basic_blob(self):
         self.blob = SettingsBlob()
         self.blob.loadJSON(_DATA)
-        self.assertTrue(self.blob.validate())
+        self.blob.validate()
 
         update_query = {
             "product": "gg", "version": "3", "buildID": "1",

auslib/test/blobs/test_whitelist.py

@@ -21,7 +21,7 @@ class TestWhitelist(unittest.TestCase):
     def test_whitelist_blob(self):
         self.blob = WhitelistBlobV1()
         self.blob.loadJSON(_DATA)
-        self.assertTrue(self.blob.validate())
+        self.blob.validate()
 
         update_query = {
             "product": "b2g", "version": "2.5", "buildID": "1",