Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test travis on python 2.6 #17

Merged
merged 4 commits into from Nov 26, 2014
Merged

test travis on python 2.6 #17

merged 4 commits into from Nov 26, 2014

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Nov 26, 2014

Since our production server is 2.6 we ought to test on it.

I think it's a good idea to keep the tests for 2.7 too because hopefully some time soon we'll join the future too.

@peterbe
Copy link
Contributor Author

peterbe commented Nov 26, 2014

@bhearsum r?

@@ -10,3 +10,4 @@ blinker==1.2
cef==0.5
flask-compress==1.0.2
itsdangerous==0.24
ordereddict==1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything in prod.txt needs to be put into the vendor library. Perhaps it's easier to stop depending on ordereddict, instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ordereddict is awesome. I'll update the vendor library too.

@peterbe
Copy link
Contributor Author

peterbe commented Nov 26, 2014

Actually I change my mind (referring to the point of adding it to vendor/lib).
We only need ordereddict in for running tests. This is equally true for mock, nose etc. which are things in requirements/dev.txt.

@bhearsum
Copy link
Contributor

Perfect!

bhearsum pushed a commit that referenced this pull request Nov 26, 2014
@bhearsum bhearsum merged commit 6a9bc56 into mozilla-releng:master Nov 26, 2014
JohanLorenzo pushed a commit to JohanLorenzo/balrog that referenced this pull request Sep 9, 2016
…ersion

bug 741412: remove 'version' from releases UI. r=nthomas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants