Pin "debug" package to less than 4.0 #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in #826 @allan-silva discovered that we can't build the Balrog UI from scratch, which is a big deal because that's how we build our images for deployment. This is a quick patch to pin an older version of the node package called
debug, so that we could deploy an emergency fix to Balrog code if needed.The root cause is that we're using older Node (v0.10) that doesn't support arrow functions, which the
debugpackage started using in 4.0.debugis pulled in indirectly by other packages, the usual vipers nest of package deps. We'll test upgrading to Node v8 over in #826 but can't deploy that so close to 63.0 shipping.