New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to get the state of the Rules table at a point in time #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nthomas-mozilla
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool how little backend code needs to change to support this great new functionality. I don't have any blockers, but would be happy to see a few tweaks for readability. No firm opinion on the alternative parameters for /rules
requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between the unit tests included and my own manual testing this looks like it works as expected. I'm using
<= timestamp
, because I think that desirable to return Rules up to and including the point in time, rather than just before it. Let me know if that doesn't make sense.I'm not 100% happy with the state of the parameters to /rules in the current state. If you pass timestamp, product is ignored, and visa versa. In theory we could let
getPointInTime
restrict by product, but there's no use case for it, so I'm not sure it's worthwhile to implement. Maybe just an error message if both are passed is sufficient? I'm interested in what you think.If you want to test this with real data, you should be able to run mozilla-releng/balrog-ui#135 locally (make sure to comment out the react UI container from this repo's docker-compose.yml, though) together with this patch.