Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for up to date udfs in queries #148

Closed
relud opened this issue May 17, 2019 · 2 comments
Closed

Add test for up to date udfs in queries #148

relud opened this issue May 17, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@relud
Copy link
Collaborator

relud commented May 17, 2019

for each function in udf/ we should test that if used in a query in sql/ the function should be present at the top of the query and actually match the code provided in udf/

@relud relud added the enhancement New feature or request label May 17, 2019
@jklukas
Copy link
Contributor

jklukas commented May 21, 2019

I am starting into implementation for a first phase of #141. I am hoping that phase two can involve injecting udfs to the top of queries, in which case we can remove them from the source files and not have to worry about testing this.

@jklukas
Copy link
Contributor

jklukas commented Jul 23, 2019

This is no longer needed now that we have templates.

@jklukas jklukas closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants