Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type stubs for bleach #424

Closed
srittau opened this issue Dec 20, 2018 · 4 comments
Closed

Type stubs for bleach #424

srittau opened this issue Dec 20, 2018 · 4 comments

Comments

@srittau
Copy link

srittau commented Dec 20, 2018

For my own use, I have written type stubs for bleach: https://github.com/srittau/python-stubs/tree/master/stubs/bleach. With your permission I would like to include them in typeshed so they get included in future releases of type checkers like mypy.

The stubs are mostly complete, just the two html5lib filter classes are incomplete, partly because html5lib does not have type stubs, yet.

@willkg
Copy link
Member

willkg commented Dec 20, 2018

That sounds fine as long as it doesn't add work or additional obligations for me. If it does add work or obligations for me, then I'd like to understand what that work is before I commit to anything.

@srittau
Copy link
Author

srittau commented Dec 21, 2018

No work or obligations on your part. Typeshed contributors will maintain the stubs. It is my hope that eventually more packages will start shipping their own stubs (possibly by starting with the typeshed ones) per PEP 561, but this purely optional and maturing stubs in typeshed is a good idea anyway.

@willkg
Copy link
Member

willkg commented Dec 21, 2018

That sounds fine with me! Let me know if you need help with figuring out signatures, though... sounds like you're all set already.

@willkg
Copy link
Member

willkg commented Dec 28, 2018

Seems like there's no work to be done here, so I'm going to close this out.

@willkg willkg closed this as completed Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants