Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

The "Add another email" string is not localized #1333

Closed
ghost opened this issue Mar 23, 2012 · 7 comments
Closed

The "Add another email" string is not localized #1333

ghost opened this issue Mar 23, 2012 · 7 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 23, 2012

OS: Windows 7
Browser: Firefox 12.0 beta 2
Language: German, Finnish (probably more languages)

STR:

  1. Load http://beta.myfavoritebeer.org/ in the browser.
  2. Click on the Sign In button and sign into an account.
  3. Observe the emails list dialog.

The "Add another email" string is not translated.

@jbonacci
Copy link
Contributor

Good catch @ioanab !
String was changed as part of #403.

mathjazz or @ozten - do the localizers know about this string change?

@ozten
Copy link
Contributor

ozten commented Apr 2, 2012

http://temporary_preview.myfavoritebeer.org/ does have the latest code - this is my bad.

in svn
locale/es/LC_MESSAGES/client.po:msgid "Add another email"
locale/es/LC_MESSAGES/client.po-msgstr "Agregar otro correo"

Stage looks good:
https://diresworb.org/i18n/es/client.json has the string
I see it on http://beta.myfavoritebeer.org/

Production:
https://browserid.org/i18n/es/client.json - missing strings

Next steps... Do we need to evaluate if we should do an out of cycle release to pick up the latest strings? Are all the affected locales ready?

@mathjazz
Copy link
Contributor

mathjazz commented Apr 3, 2012

I will make a list of all the affected locales.

Yes, I we should do an out of cycle release ASAP.

@mathjazz
Copy link
Contributor

mathjazz commented Apr 3, 2012

This is the list:
"ca", "el", "es", "fr", "fy", "ga", "gl", "hr", "hu", "it", "lt", "pa", "sl", "tr"

@mathjazz
Copy link
Contributor

Works for me in production.

@jbonacci
Copy link
Contributor

OK. We will have another look at this on the next train (2012-04-11).

@jbonacci
Copy link
Contributor

Assuming fixed per @mathjazz comments above. The locales I tested look good in Prod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants