Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

optimize RP page load time with new APIs #1351

Closed
lloyd opened this issue Mar 29, 2012 · 4 comments
Closed

optimize RP page load time with new APIs #1351

lloyd opened this issue Mar 29, 2012 · 4 comments

Comments

@lloyd
Copy link
Contributor

lloyd commented Mar 29, 2012

Given that the new APIs we're landing will include more resources at RP load time, we should spend some time optimizing page load times. Concretely, the "communication iframe" will be placed in the user's dom at the time they interact with browserid's APIs, often around or before the DOM is loaded.

The two things we should explore are:

  1. remove unused resources from vepbundle (~30% of cost)
  2. remove our depenency on jquery (another ~30% of cost)

This work should be done before we start talking about the new APIs, probably before april 11th.

/cc @ozten @shane-tomlinson @benadida

@ghost ghost assigned benadida Mar 29, 2012
lloyd added a commit that referenced this issue Mar 29, 2012
…frame

For the communication iframe, removing jQuery and adding micrajax. issue #1351
@jbonacci
Copy link
Contributor

This issue is marked Verified but Open. Should this be marked Close?

@jbonacci
Copy link
Contributor

Removed Verified tag since there is no context for it.

@shane-tomlinson
Copy link

@jbonacci - this should be closed. The main problem is the communication_iframe included jQuery, which was 135kb. Within the communication_iframe, the only part of jQuery that we used was the ajax functionality. Since we perform no DOM manipulation from the communication_iframe, the rest of jQuery was wasteful. We have since removed jQuery from the communication iframe and added micrajax which saves a considerable number of KBs. Closing as fixed.

@jbonacci
Copy link
Contributor

OK. Sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants