Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Date and time of signin badly formatted #191

Closed
joshtriplett opened this issue Aug 21, 2011 · 7 comments
Closed

Date and time of signin badly formatted #191

joshtriplett opened this issue Aug 21, 2011 · 7 comments

Comments

@joshtriplett
Copy link

I currently see "Signed in at 1:4:26, 7/0/2011". That seems wong. :)

@lloyd
Copy link
Contributor

lloyd commented Aug 22, 2011

so we'll zero pad minutes and base 1 day.

For reference, this is on the manage page and code is here: ./browserid/static/js/browserid.js

@lloyd lloyd closed this as completed in e5e3224 Aug 22, 2011
@lloyd
Copy link
Contributor

lloyd commented Aug 22, 2011

you can test this on http://dev.myfavoritebeer.org and https://dev.diresworb.org

@jbonacci jbonacci reopened this Aug 22, 2011
@jbonacci
Copy link
Contributor

My comment seems to have gotten hosed.
Anyway...
I still see this in Beta: Signed in at 15:5:55, 7/1/2011

Note 2 things:

  1. the :5: should be :05: to get the 24-hour formatting correct
  2. The date is wrong, today is 8/22/2011.

Also, we need to think about a more universal date format unless we want to use one for US and another for Intl.

@shane-tomlinson
Copy link

@jbonacci: Can you check this on dev, as @lloyd put in a fix for it.

@lloyd
Copy link
Contributor

lloyd commented Aug 23, 2011

thanks @shane-tomlinson,

you can the fix on http://dev.myfavoritebeer.org and https://dev.diresworb.org (and it's NOT on beta yet).

Closing, please re-open if I'm missing something.

@lloyd lloyd closed this as completed Aug 23, 2011
@jbonacci
Copy link
Contributor

Beta: this seems a lot better:
"Signed in at Wed Aug 31 11:34:19 2011"

@jbonacci
Copy link
Contributor

Verified in the 8/25/2011 train in Beta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants