Conversation
fabulous! gets reviewing goggles |
res.json({ 'public-key': publicKey.toSimpleObject() }); | ||
res.json({ | ||
'public-key': publicKey.toSimpleObject(), | ||
'provisioning': '/provision', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent is off
So... The devil hiding in the details, password resets and transition states. Are they going to be handled? |
Can we land this and start getting UX feedback, before implementing those features? |
Trying to get awsbox working, I've merged from dev, but got bitrot for the second time. I was able to see that logging.js moved and fix that. The other issue is that the dialog just comes up blank. To unblock myself, I've copied over scripts/deploy.js and changed the dependency to awsbox@0.6.2... but we'll have to figure out what changed about the dialog code that has broken the initial screen display for the new /auth screen. Any ideas? |
@ozten I'll do some git twiddling on Monday, see if I can cleanly apply your changes on top of current dev. |
ok, looking now. |
@ozten nice work so far! I was able to cleanly cherry-pick all the changes onto current dev (except for the commits merging dev into this branch). My branch is at https://github.com/6a68/browserid/tree/issue-2497-idp-rebased-not-merged. One tiny logging path change was needed to get tests running, that's on the HEAD of that branch, a7fd566. The local RP seems fine to me on my branch, I can log in and out. |
@6a68 is rocking the merge from dev to update this branch, you rule! Please try to reproduce the blank dialog I was seeing. You can download a Persona enabled Desktop build: Set a couple preferences (about:config):
Restart Firefox. dom.identity.persona_fallback defaults to our new ephemeral server https://desktoppersona.personatest.org/ but you can change this to any environment. Steps to reproduce:
Actual: empty dialog Expected: prompt to set a password |
@ozten happy to help :-) I've got the special FF build, I toggled the settings you mentioned (actually tried using the desktoppersona fallback as well as localhost), but I'm not sure what to do next. When I try to log into RPs, I click the persona button but nothing happens. Tried 123done, mozillians, nothing. Also not seeing errors in the JS console--maybe there's a desktop-specific console for the native code that I'm unaware of? I'll poke a bit more at my branch and yours, see if I can at least get an empty dialog using your branch. |
It looks like the blank dialog error was caused by using hashes, but the recently-landed #3971 I think means we should be using querystring instead. @ozten said this got him past the blank dialog problem in a local branch, I've updated my issue-2497-idp-rebased-not-merged branch with the fix (commit (9e8ed0f)[https://github.com/6a68/browserid/commit/9e8ed0f]). |
@ozten i don't have the The second image is broken for me. |
Thanks Jared! Using your patch, I see Thanks for continuing to dig for breaking changes from merging. |
I have my current branch running on https://rebasedidp.personatest.org. Will pick this up again in the morning. 🍻 |
heh, I caused the Relay Error: we look for the hash, not the querystring, when we setup the channel. Removing that, or changing that code to look for ?NATIVE as window.location.search, returns us to the mysterious empty dialog situation we had before. Continuing to dig. |
* Create RpInfo before starting the modules. Hard coding the origin and rpName for now * Update IdpAuthentication module to pass RpInfo to the appropriate modules. * Start the check_registration module instead of calling user.waitForUserValidation since it already takes care of error messages.
@fmarier or @shane-tomlinson I've removed temporary hacks, console.log, etc. We should be good to merge as discussed. General note: The Goldilocks API breaks the Native implementation, so use http://192.168.186.138:10001/watch.html instead of http://192.168.186.138:10001/ |
G R E E N |
mediator.subscribe("new_user", newUserComplete(self)); | ||
|
||
var rpInfo = bid.Models.RpInfo.create({ | ||
origin: "http://127.0.0.1:10001", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to take these out?
r+ from me. makes Travis happy. tested by Shane and Austin. |
All the man needed was a Guiness at the airport! Thanks! |
This allows the verifier to work-around a Persona bug that has been fixed (mozilla/persona#3982) but not yet deployed. Fixes mozilla#19
Background for pull request: Issue #2497 (comment)
Creating a pull request to try to get some frontend help.
Thanks to @shane-tomlinson for previously reviewing and getting it this far.
Known Issues:
Needs Frontend <3