Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugBot shouldn't nag for unlanded patches that have reminder- whiteboard tags #2096

Closed
gijsk opened this issue Jun 6, 2023 · 2 comments · Fixed by #2108
Closed

BugBot shouldn't nag for unlanded patches that have reminder- whiteboard tags #2096

gijsk opened this issue Jun 6, 2023 · 2 comments · Fixed by #2108
Assignees

Comments

@gijsk
Copy link
Contributor

gijsk commented Jun 6, 2023

Especially for bugs split off from security ones where the tests need to land substantially later than the original patch, it's not uncommon to have r+'d test patches sit for a month or two. I tend to use [reminder-test <date>] to get the bot to tell me when it's time to land them.

Unfortunately, the bot also needinfos me and the reviewer 2 weeks after the patches have been r+'d (and perhaps repeatedly after that? I haven't yet waited that out) to ask when we're landing the patches. It would be nice if it didn't.

@suhaibmujahid suhaibmujahid changed the title Autonag shouldn't nag for unlanded patches that have reminder- whiteboard tags BugBot shouldn't nag for unlanded patches that have reminder- whiteboard tags Jun 8, 2023
@suhaibmujahid
Copy link
Member

Thank you @gijsk for reporting this. The suggestion seems sound to me. Could you please share an example of a bug with such a case?

@gijsk
Copy link
Contributor Author

gijsk commented Jun 9, 2023

@suhaibmujahid https://bugzilla.mozilla.org/show_bug.cgi?id=1832266 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants