Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the flake8 warnings #9

Closed
sylvestre opened this issue Apr 14, 2015 · 5 comments
Closed

Fix the flake8 warnings #9

sylvestre opened this issue Apr 14, 2015 · 5 comments

Comments

@sylvestre
Copy link
Contributor

Flake8 is finding a bunch of issues wrt the python code. We should fix them: (but we don't care about the max line length check)

$ flake8 --max-line-length=10800  scripts/ bugzilla/ templates/
scripts/attach.py:8:1: F401 'Bug' imported but unused
scripts/attach.py:10:1: F401 'qs' imported but unused
scripts/attach.py:14:1: E302 expected 2 blank lines, found 1
scripts/attach.py:35:16: E128 continuation line under-indented for visual indent
scripts/attach.py:91:1: E302 expected 2 blank lines, found 1
scripts/automated_release_emails.py:23:9: E128 continuation line under-indented for visual indent
scripts/automated_release_emails.py:24:9: E128 continuation line under-indented for visual indent
scripts/automated_release_emails.py:25:9: E128 continuation line under-indented for visual indent
scripts/automated_release_emails.py:26:9: E128 continuation line under-indented for visual indent
scripts/automated_release_emails.py:27:9: E128 continuation line under-indented for visual indent
scripts/automated_release_emails.py:28:9: E128 continuation line under-indented for visual indent
scripts/b2g_query_creator.py:35:22: E261 at least two spaces before inline comment
scripts/b2g_query_creator.py:87:127: E231 missing whitespace after ','
scripts/b2g_query_creator.py:88:125: E231 missing whitespace after ','
scripts/b2g_query_creator.py:89:118: E231 missing whitespace after ','
scripts/b2g_query_creator.py:90:116: E231 missing whitespace after ','
scripts/b2g_query_creator.py:91:119: E231 missing whitespace after ','
scripts/b2g_query_creator.py:92:117: E231 missing whitespace after ','
scripts/b2g_query_creator.py:93:134: E231 missing whitespace after ','
scripts/b2g_query_creator.py:94:132: E231 missing whitespace after ','
scripts/email_nag.py:77:35: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:88:31: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:92:34: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:100:25: E126 continuation line over-indented for hanging indent
scripts/email_nag.py:126:5: E303 too many blank lines (2)
scripts/email_nag.py:142:9: E128 continuation line under-indented for visual indent
scripts/email_nag.py:143:9: E128 continuation line under-indented for visual indent
scripts/email_nag.py:144:9: E128 continuation line under-indented for visual indent
scripts/email_nag.py:145:9: E128 continuation line under-indented for visual indent
scripts/email_nag.py:146:9: E128 continuation line under-indented for visual indent
scripts/email_nag.py:150:19: E231 missing whitespace after ','
scripts/email_nag.py:153:21: E231 missing whitespace after ','
scripts/email_nag.py:153:25: E231 missing whitespace after ','
scripts/email_nag.py:153:34: E231 missing whitespace after ','
scripts/email_nag.py:153:43: E231 missing whitespace after ','
scripts/email_nag.py:162:33: E231 missing whitespace after ','
scripts/email_nag.py:183:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:185:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:187:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:189:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:190:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:192:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:193:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:195:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:196:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:197:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:199:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:200:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:202:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:203:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:205:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:207:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:209:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:211:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:213:13: E128 continuation line under-indented for visual indent
scripts/email_nag.py:242:37: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:249:20: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:252:20: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:255:22: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:258:17: E265 block comment should start with '# '
scripts/email_nag.py:277:24: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:280:21: E126 continuation line over-indented for hanging indent
scripts/email_nag.py:280:26: E203 whitespace before ':'
scripts/email_nag.py:285:17: E121 continuation line under-indented for hanging indent
scripts/email_nag.py:287:35: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:288:50: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:296:64: E203 whitespace before ','
scripts/email_nag.py:304:21: E126 continuation line over-indented for hanging indent
scripts/email_nag.py:304:26: E203 whitespace before ':'
scripts/email_nag.py:308:22: E121 continuation line under-indented for hanging indent
scripts/email_nag.py:309:17: E121 continuation line under-indented for hanging indent
scripts/email_nag.py:323:43: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:333:34: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:368:44: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:373:46: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:375:52: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:377:58: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:379:56: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:388:61: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:391:60: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:403:21: E126 continuation line over-indented for hanging indent
scripts/email_nag.py:407:27: E251 unexpected spaces around keyword / parameter equals
scripts/email_nag.py:407:29: E251 unexpected spaces around keyword / parameter equals
scripts/email_nag.py:408:32: E251 unexpected spaces around keyword / parameter equals
scripts/email_nag.py:408:34: E251 unexpected spaces around keyword / parameter equals
scripts/email_nag.py:419:20: W601 .has_key() is deprecated, use 'in'
scripts/email_nag.py:477:21: E128 continuation line under-indented for visual indent
scripts/email_nag.py:478:21: E128 continuation line under-indented for visual indent
scripts/email_nag.py:479:21: E128 continuation line under-indented for visual indent
scripts/email_nag.py:480:21: E128 continuation line under-indented for visual indent
bugzilla/__init__.py:1:20: E231 missing whitespace after ','
bugzilla/__init__.py:1:28: E231 missing whitespace after ','
bugzilla/agents.py:1:1: F403 'from bugzilla.models import *' used; unable to detect undefined names
bugzilla/agents.py:2:1: F403 'from bugzilla.utils import *' used; unable to detect undefined names
bugzilla/agents.py:4:1: E302 expected 2 blank lines, found 1
bugzilla/agents.py:10:1: E302 expected 2 blank lines, found 1
bugzilla/agents.py:12:1: W293 blank line contains whitespace
bugzilla/models.py:33:1: E302 expected 2 blank lines, found 1
bugzilla/models.py:233:1: W293 blank line contains whitespace
bugzilla/models.py:234:45: W292 no newline at end of file
bugzilla/utils.py:17:10: E231 missing whitespace after ','
bugzilla/utils.py:21:47: E231 missing whitespace after ','
bugzilla/utils.py:32:50: W291 trailing whitespace
bugzilla/utils.py:54:25: E221 multiple spaces before operator
@anoopvalluthadam
Copy link
Contributor

anoopvalluthadam@3bdf7c0

@anoopvalluthadam
Copy link
Contributor

Could you please check the fix.

@sylvestre
Copy link
Contributor Author

Looks good but could you do a pull request? Thanks

@lavish205
Copy link

I would like to work on it.

@sylvestre
Copy link
Contributor Author

@luckylavish This was fixed by this PR I believe #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anoopvalluthadam @sylvestre @lavish205