Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbindgen MSRV #773

Open
petreeftime opened this issue Aug 1, 2022 · 3 comments
Open

cbindgen MSRV #773

petreeftime opened this issue Aug 1, 2022 · 3 comments

Comments

@petreeftime
Copy link

The MSRV for cbindgen doesn't seem to be strictly adhered to:

  • The README.md file specifies the MSRV is 1.32
  • The CI indicates that the version tested is in fact 1.54
  • indexmap, a dependency of the project requires 1.56 and pulls in hashbrown, which actually requires 1.56 due to support for edition 2021

Can the requirements be made a bit clearer with regards to the MSRV?

Would it be possible to release a minor version of cbindgen that has the indexmap dependency specified in such a way that 2021 edition / 1.56 is not strictly required? You have to go back quite a bit, to 0.15 for this to be true.

@petrochenkov
Copy link
Contributor

MSRV tested on CI was 1.40 for quite some time.
Apparently it was significantly increased in d4e508d to support clap 3.

@jschwe
Copy link
Contributor

jschwe commented Mar 8, 2023

indexmap, a dependency of the project requires 1.56 and pulls in hashbrown, which actually requires 1.56 due to support for edition 2021

Is this still a problem? I can currently build with 1.54 locally without problems.

Can the requirements be made a bit clearer with regards to the MSRV?

I opened a PR to adjust the MSRV specified in the README badge and the clippy.toml: #816

@diligence5087
Copy link

This issue can probably be closed since #912 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants