Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative value in mozlint tasks crashes the bot #265

Closed
La0 opened this issue Nov 25, 2019 · 7 comments
Closed

Negative value in mozlint tasks crashes the bot #265

La0 opened this issue Nov 25, 2019 · 7 comments
Assignees
Labels
bot Code review bot bug Something isn't working duplicate This issue or pull request already exists

Comments

@La0
Copy link
Contributor

La0 commented Nov 25, 2019

See https://firefoxci.taskcluster-artifacts.net/Zs4uj7w6Q3ylEuC4fPhhgA/0/public/logs/live_backing.log

@La0 La0 added bug Something isn't working bot Code review bot labels Nov 25, 2019
@La0 La0 self-assigned this Nov 25, 2019
@marco-c
Copy link
Collaborator

marco-c commented Nov 26, 2019

So I guess #175 was not complete?

@marco-c
Copy link
Collaborator

marco-c commented Nov 26, 2019

It's strange because we are supposed to convert -1 to None at

self.line = positive_int("line", line)
, and then contains should return early when line is None: .

Instead, it seems like we are getting to

lines = set(range(issue.line, issue.line + issue.nb_lines))
.

@La0
Copy link
Contributor Author

La0 commented Nov 26, 2019

We are just not running the recent code in prod.
Doing a release now seems like a really good idea...

@marco-c
Copy link
Collaborator

marco-c commented Nov 26, 2019

Aaaah, that explains everything :P

@La0
Copy link
Contributor Author

La0 commented Nov 26, 2019

We should be good now that 1.0.7 has landed

@marco-c marco-c added the duplicate This issue or pull request already exists label Nov 26, 2019
@marco-c
Copy link
Collaborator

marco-c commented Nov 26, 2019

So we can close as duplicate of #168.

@marco-c marco-c closed this as completed Nov 26, 2019
@La0
Copy link
Contributor Author

La0 commented Nov 26, 2019

I tested locally with current master, seems to work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot Code review bot bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants