Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopend tab should inherit openerTabId from the original tab #727

Open
piroor opened this issue Feb 10, 2021 · 0 comments · May be fixed by #844
Open

Reopend tab should inherit openerTabId from the original tab #727

piroor opened this issue Feb 10, 2021 · 0 comments · May be fixed by #844
Labels
enhancement New feature or request

Comments

@piroor
Copy link

piroor commented Feb 10, 2021

Is your feature request related to a problem? Please describe.

It was originally reported to Tree Style Tab's issue tracker:
piroor/treestyletab#1677

When a facebook tab is opened from a pinned tab, the opened tab has the id of the opener pinned tab as its openerTabId, and TST controls position of the tab based on the information. However, when the tab is closed and reopened by Facebook Container, the reopened tab has no openerTabId so TST cannot handle it as configured for tabs opened from a pinned tab.

Describe the solution you'd like

Inheriting of openerTabId from the original tab to the reopened version. It looks to improve compatibility with other tab related addons not only TST.

Describe alternatives you've considered

Currently I have no other alternative idea.

Additional context
@piroor piroor added the enhancement New feature or request label Feb 10, 2021
@piroor piroor mentioned this issue Feb 10, 2021
Closed
mbnuqw added a commit to mbnuqw/contain-facebook that referenced this issue May 21, 2022
@mbnuqw
Use the openerTabId of the source tab
ac7f508 
Fixes mozilla#727
@mbnuqw mbnuqw linked a pull request May 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the openerTabId of the source tab mbnuqw/contain-facebook
1 participant
@piroor