Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

First/Last name not passed to basket #61

Closed
cadecairos opened this issue Mar 10, 2017 · 11 comments
Closed

First/Last name not passed to basket #61

cadecairos opened this issue Mar 10, 2017 · 11 comments
Assignees

Comments

@cadecairos
Copy link
Contributor

We need to pass the firstName and lastName fields submitted by the form to sawmill. This should happen here:

var payload = {
format: 'html',
lang: transaction.locale,
newsletters: 'mozilla-foundation',
trigger_welcome: 'N',
source_url: 'https://changecopyright.org/',
email: transaction.email,
country: transaction.country
};

cc/ @stephaniemcv @ScottDowne

@stephaniemcv
Copy link

Actually, this might not be a blocker at all. Because all that info is going into a sheet, yes? We can update First Name, Last Name at that time the we import signatures.

@hannahkane
Copy link

My understanding is there's not a sheet for this, since it's just collecting email sign-ups; it's not a petition. @ScottDowne to confirm.

@stephaniemcv
Copy link

Oh yeah, you're right. I keep thinking Copyright is a petition again.

@ScottDowne
Copy link
Contributor

Good catch.

  1. We can fix this before it's a problem in copyright.
  2. Open data ALSO has this bug. In that case, we very much need the sheets to get the names.

@ScottDowne ScottDowne self-assigned this Mar 10, 2017
@ScottDowne
Copy link
Contributor

ScottDowne commented Mar 10, 2017

Should be fixed in copyright now.

@stephaniemcv
Copy link

I will qa right now.

@stephaniemcv
Copy link

Nope. They still didn't pass through.

@ScottDowne
Copy link
Contributor

ScottDowne commented Mar 10, 2017 via email

@stephaniemcv
Copy link

Sounds good!

@stephaniemcv
Copy link

Confirm. First Name and Last Name is passing. Locale is correctly checking language and source url is passing as well.

@ScottDowne
Copy link
Contributor

Cool, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants