Skip to content
This repository has been archived by the owner on Jan 28, 2019. It is now read-only.

URLs for build and tests are not html encoded (space breaks download) #35

Closed
whimboo opened this issue Jul 4, 2014 · 2 comments
Closed

URLs for build and tests are not html encoded (space breaks download) #35

whimboo opened this issue Jul 4, 2014 · 2 comments

Comments

@whimboo
Copy link
Contributor

whimboo commented Jul 4, 2014

As seen in our tps runs for beta builds, the download of the build and tests is broken because the URLs contain a whitespace. We might have to htmlencode the URL or adjust the trigger script to pass it in correctly within quotes.

Here the example:

URL_BUILDS: http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/31.0b7-candidates/build1/mac/en-US/Firefox 31.0b7.dmg
URL_TESTS: http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/31.0b7-candidates/build1/mac/en-US/Firefox 31.0b7.tests.zip
@whimboo whimboo self-assigned this Jul 4, 2014
@whimboo
Copy link
Contributor Author

whimboo commented Jul 4, 2014

I will try to get this fixed soonish.

@whimboo whimboo mentioned this issue Jul 4, 2014
Merged
@whimboo
Copy link
Contributor Author

whimboo commented Jul 4, 2014

PR #36 has been merged.

@whimboo whimboo closed this as completed Jul 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whimboo