Skip to content
This repository has been archived by the owner on Feb 18, 2019. It is now read-only.

default of protocol check somewhat sketchy #19

Open
k0s opened this issue Aug 6, 2012 · 0 comments
Open

default of protocol check somewhat sketchy #19

k0s opened this issue Aug 6, 2012 · 0 comments

Comments

@k0s
Copy link
Contributor

k0s commented Aug 6, 2012

    if protocol in self.protocols:
        self.protocol = protocol
    else:
        #Default to https
        self.protocol = 'https'

This is fine if the protocol is None, but if you pass in, say, 'ftp' or some other unsupported protocol this isn't what you want and it should probably err out instead of using https

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant