Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

default of protocol check somewhat sketchy #19

Open
k0s opened this Issue Aug 6, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

k0s commented Aug 6, 2012

    if protocol in self.protocols:
        self.protocol = protocol
    else:
        #Default to https
        self.protocol = 'https'

This is fine if the protocol is None, but if you pass in, say, 'ftp' or some other unsupported protocol this isn't what you want and it should probably err out instead of using https

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment