Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email login: Add a disclaimer #123

Closed
davidhedlund opened this issue Jan 22, 2018 · 19 comments
Closed

Email login: Add a disclaimer #123

davidhedlund opened this issue Jan 22, 2018 · 19 comments

Comments

@davidhedlund
Copy link

davidhedlund commented Jan 22, 2018

Describe the problem and steps to reproduce it:

https://discourse.mozilla.org/ -> Log In / Sign Up

  • LOG IN WITH EMAIL -> youremail@example.com (real mail provided of course), SEND EMAIL -> "We sent you a link to sign in. Please check your e-mail and open the provided link in this web browser."

What happened?

When I open the link provided in the email I get this error.

screenshot from 2018-02-11 02 12 11

What did you expect to happen?

I should have been logged in.

Anything else we should know?

There's no Contact link or similar at https://discourse.mozilla.org/, please add this repository to the page to make it clear where people should submit bugs.

┆Issue is synchronized with this Jira Task

@hmitsch
Copy link
Contributor

hmitsch commented Jan 28, 2018

Hi @davidhedlund,

do you have a profile on Mozillians.org? If yes, can you please send us the link to it? We can then have a better look into this issue.

Best regards,
Henrik

/cc @LeoMcA @flamingspaz @akatsoulas @johngian

@davidhedlund
Copy link
Author

@hmitsch No I have not. But I have logged in before, see https://discourse.mozilla.org/users/davidhedlund/

@LeoMcA
Copy link
Contributor

LeoMcA commented Jan 29, 2018

Hi David,

As the error message describes, you'll need to log in to Discourse using Github from now on.

We're tracking making this experience better here: mozilla-iam/auth0-deploy#166

There's no Contact link or similar at https://discourse.mozilla.org/, please add this repository to the page to make it clear where people should submit bugs.

There's a contact email listed on https://discourse.mozilla.org/about

@davidhedlund
Copy link
Author

@LeoMcA Hahaha, what a wonderful avatar!

@davidhedlund
Copy link
Author

davidhedlund commented Jan 29, 2018

@LeoMcA Why not remove the "LOG IN WITH EMAIL"? There's no need to display it if we cannot use it. It will only continue to cause distrust in the Discourse infrastructure.

@LeoMcA
Copy link
Contributor

LeoMcA commented Feb 1, 2018

@LeoMcA Hahaha, what a wonderful avatar!

Thanks

@LeoMcA Why not remove the "LOG IN WITH EMAIL"? There's no need to display it if we cannot use it. It will only continue to cause distrust in the Discourse infrastructure.

One can use it, but you cannot - because you've logged in with github previously. Users who haven't logged in with github or google previously can continue to log in with email.

Discussion about that isn't a Discourse issue but a wider IAM one, so I'm closing this bug. If you have any further problems authenticating please reach out to us using the contact email listed on https://discourse.mozilla.org/about

@LeoMcA LeoMcA closed this as completed Feb 1, 2018
@davidhedlund
Copy link
Author

@LeoMcA Why not add a disclaimer if I fail to login with the mail that reads something like this?:

You cannot login with mail because you've logged in with GitHub previously.

@davidhedlund davidhedlund changed the title Email login problem Email login: Add a disclaimer Feb 1, 2018
@davidhedlund
Copy link
Author

@LeoMcA Great. I changed the title, should the issue be re-opened?

@edmorley
Copy link

The error message comes from the sso-dashboard, which has just been updated (possibly not deployed yet) to make the reason clearer. See mozilla-iam/sso-dashboard#215.

@davidhedlund
Copy link
Author

davidhedlund commented Feb 10, 2018

@edmorley Thank you very much. Can you re-open this issue?

@edmorley
Copy link

I'm not involved with the discourse instance and don't have permissions on this GitHub project. However given the message wording has been tweaked, I'm not sure what is left to do here? (The "There's no Contact link" part of the OP should probably be a separate issue etc)

@davidhedlund
Copy link
Author

@edmorley Ok, thanks again.

@davidhedlund
Copy link
Author

I still get this error.
screenshot from 2018-02-11 02 12 11

@edmorley
Copy link

(possibly not deployed yet)

See:
mozilla-iam/sso-dashboard#215 (comment)

@davidhedlund
Copy link
Author

davidhedlund commented Feb 11, 2018

@edmorley Ok. I just think this bug should be re-opened until this has been fixed.

@hmitsch
Copy link
Contributor

hmitsch commented Feb 11, 2018

@davidhedlund: you are right, let’s reopen the issue. We shall close it, once the tweaked error message lands in production.

@edmorley: thanks a lot for handling comms on this ticket. This is very helpful! And of course you are right, the tweaked message has only landed on staging. We will test this early next week and hope to deploy before the mid of the week.

-Henrik

@hmitsch hmitsch reopened this Feb 11, 2018
@davidhedlund
Copy link
Author

@hmitsch I wish you good luck.

@LeoMcA
Copy link
Contributor

LeoMcA commented Mar 7, 2019

This shouldn't be an issue any more as most users are now allowed to log in with passwordless even if they've previously logged in with github: https://discourse.mozilla.org/t/mozilla-discourse-release-2019-02-27/36283

@LeoMcA LeoMcA closed this as completed Mar 7, 2019
@davidhedlund
Copy link
Author

This shouldn't be an issue any more as most users are now allowed to log in with passwordless even if they've previously logged in with github: https://discourse.mozilla.org/t/mozilla-discourse-release-2019-02-27/36283

Thanks, there are now four ways to login, not just with GitHub

screenshot at 2019-03-07 21 53 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants