Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(UI) Move common prop sets (based on flows/experiment status) to central location #5851

Closed
data-sync-user opened this issue Jun 25, 2021 · 1 comment

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 25, 2021

We have a lot of sets of properties for various experiment flows and/or states for use in Storybook, testing, and in our mutations. It feels like these could go in some sort of shared location, or a shared flow/prop mock file and another for reference in the UI.

We have some great "[state]BaseProps" in ChangeApprovalOperations mocks. I think we can pull these out to a higher level to use across stories where applicable, there's likely other stories (and potentially tests) like in AppLayoutWithSidebar and LinkNavSummary tests that could pull from a shared place, and we have other "base props" set up in Summary mocks as well as in PageSummary.

Additionally, we have a lot of flow actions for mutations that correspond to similar sets of "flow props". See this in PageSummary as well as one in Summary.

There may be other similar instances - just mostly feels like this could use some consolidation and something that can make these properties/objects correspond with a kind of flow or action would feel a bit cleaner.

Related, fixing up how we're checking for statuses: EXP-1158 / #5643

┆Issue is synchronized with this Jira Task

@jaredlockhart
Copy link
Collaborator

@lmorchard if you feel like doing this soon then great, if not then just close this as a wontfix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants