You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a lot of sets of properties for various experiment flows and/or states for use in Storybook, testing, and in our mutations. It feels like these could go in some sort of shared location, or a shared flow/prop mock file and another for reference in the UI.
Additionally, we have a lot of flow actions for mutations that correspond to similar sets of "flow props". See this in PageSummary as well as one in Summary.
There may be other similar instances - just mostly feels like this could use some consolidation and something that can make these properties/objects correspond with a kind of flow or action would feel a bit cleaner.
Related, fixing up how we're checking for statuses: EXP-1158 / #5643
We have a lot of sets of properties for various experiment flows and/or states for use in Storybook, testing, and in our mutations. It feels like these could go in some sort of shared location, or a shared flow/prop mock file and another for reference in the UI.
We have some great "[state]BaseProps" in ChangeApprovalOperations mocks. I think we can pull these out to a higher level to use across stories where applicable, there's likely other stories (and potentially tests) like in AppLayoutWithSidebar and LinkNavSummary tests that could pull from a shared place, and we have other "base props" set up in Summary mocks as well as in PageSummary.
Additionally, we have a lot of flow actions for mutations that correspond to similar sets of "flow props". See this in PageSummary as well as one in Summary.
There may be other similar instances - just mostly feels like this could use some consolidation and something that can make these properties/objects correspond with a kind of flow or action would feel a bit cleaner.
Related, fixing up how we're checking for statuses: EXP-1158 / #5643
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: