Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move labeling UI into Inspector sidebar pane #204

Open
erikrose opened this issue Aug 30, 2018 · 2 comments
Open

Move labeling UI into Inspector sidebar pane #204

erikrose opened this issue Aug 30, 2018 · 2 comments

Comments

@erikrose
Copy link
Contributor

Once https://bugzilla.mozilla.org/show_bug.cgi?id=1398734 is done, we'll be able to move our labeling UI from its current home in a separate Fathom devtools panel to a subpane of the Inspector panel. This will greatly speed the labeling experience, relieving people of pogo-sticking between the two panes.

@erikrose
Copy link
Contributor Author

erikrose commented Oct 8, 2018

It's done! Now we can work on this.

@erikrose
Copy link
Contributor Author

erikrose commented Oct 8, 2018

We might want to keep parts of the devpane on their own panel for an overview, but, at the simplest, this could look like this:

async function createPanel() {
-    const extensionPanel = await browser.devtools.panels.create(
-      'Fathom',
-        '/icons/icon.svg',
-        '/pages/devtoolsPanel.html');
-    extensionPanel.onShown.addListener(panelShowed);
-    extensionPanel.onHidden.addListener(panelHid);
+  const sidebar = await browser.devtools.panels.elements.createSidebarPane("Fathom");
+  sidebar.setPage('/pages/devtoolsPanel.html');
+  sidebar.onShown.addListener(panelShowed);
+  sidebar.onHidden.addListener(panelHid);
}

See rpl's branch at https://github.com/erikrose/fathom-fox/compare/master...rpl:experimental%2Finspector-sidebar-panel?diff=unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant