Skip to content
This repository has been archived by the owner on Apr 11, 2019. It is now read-only.

DiffViewer - Refactor state structure #68

Closed
armenzg opened this issue Nov 16, 2017 · 1 comment
Closed

DiffViewer - Refactor state structure #68

armenzg opened this issue Nov 16, 2017 · 1 comment

Comments

@armenzg
Copy link
Contributor

armenzg commented Nov 16, 2017

Currently we have appError, csetMeta, parsedDiff and we do data manipulations across all modules.
Instead I want to do all coverage and parsedDiff manipulations in DiffViewerContainer, plus store new data. The data structure will be like this:

{
  appError // as -is
  csetMeta // XXX: We will move information from 'coverage' into 'files'
  files: {
    filePath: {
       // The next two are to determine which files score worst and sort by it
      addedLines,
      coveredLines,
      folded, // To support folding files
    }
  }
}
@armenzg
Copy link
Contributor Author

armenzg commented Mar 1, 2018

I'm closing this.
The original issue is handle via the caching of the main page fetching.

@armenzg armenzg closed this as completed Mar 1, 2018
@armenzg armenzg removed this from the Release Management polishes milestone Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant