Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the doc for Activity-Stream dataset #502

Merged
merged 2 commits into from Jul 15, 2020

Conversation

ncloudioj
Copy link
Member

@SuYoungHong r?

Hey Su, I've updated this doc to reflect the current state of the Activity-Stream dataset.

Change highlights:

  • Update all the document links to the firefox source as the Github repo has been archived
  • Update the database and table names as now we've switched to Bigquery from Redshift
  • Some caveats are now invalidated with the database migration
  • Update the sample queries

Let me know what you think.

Thanks!

@ncloudioj
Copy link
Member Author

Hey @jklukas, could you (or if you know someone could) add me to the collaborators of this repo? Looks like I can't assign reviewers.

Thanks!

@jklukas
Copy link
Contributor

jklukas commented Jun 22, 2020

Hey @jklukas, could you (or if you know someone could) add me to the collaborators of this repo? Looks like I can't assign reviewers.

Done

Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ncloudioj! I had a look over this to make sure it was consistent with other material we've been writing-- hope you don't mind the drive-by review. I leave it to @SuYoungHong to check for technical correctness.

src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
src/datasets/other/activity-stream/reference.md Outdated Show resolved Hide resolved
@ncloudioj
Copy link
Member Author

Hi @ncloudioj! I had a look over this to make sure it was consistent with other material we've been writing-- hope you don't mind the drive-by review. I leave it to @SuYoungHong to check for technical correctness.

@wlach Not at all. Thanks a lot for the comments!

Will fix them up :)

@wlach wlach removed the request for review from SuYoungHong July 15, 2020 18:55
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @SuYoungHong over PM and we agreed it's best to get this landed rather than wait. Even if some adjustments need to made in a followup, this is a definite improvement over what's currently there. I'm going to approve and merge.

@wlach wlach merged commit c5c9ed9 into mozilla:master Jul 15, 2020
@ncloudioj
Copy link
Member Author

Thanks! @wlach

@ncloudioj ncloudioj deleted the update-activity-stream branch July 15, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants