Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fenix release #574

Merged
merged 7 commits into from Oct 27, 2020
Merged

Update for Fenix release #574

merged 7 commits into from Oct 27, 2020

Conversation

tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Oct 20, 2020

This needs more work, probably, but this is the ~minimal edit to avoid pointing people at the Nightly table for now.

aside: I love editing pipe tables by hand; it's great

@tdsmith tdsmith requested a review from wlach October 20, 2020 01:24
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more work, probably, but this is the ~minimal edit to avoid pointing people at the Nightly table for now.

This is good, thank you, have one suggestion re: iOS, which now uses Glean.

aside: I love editing pipe tables by hand; it's great

It's still a little painful, but don't worry too much about making sure that things align perfectly, as prettier now takes care of that for you! You can just run prettier (or better yet, get your editor to run it via format-on-save) https://github.com/mozilla/data-docs#markdown-formatting

Note that we re-run prettier on a weekly basis so no need to worry (too much) about making sure that any individual PR is formatted.

| ----------------------- | --------------------- | ------- | -------------------------------------- |
| Firefox for Android | `org_mozilla_firefox` | Android | formerly Fenix; uses Glean (see below) |
| Firefox Android (old) | `Fennec` | Android | End-of-life; replaced by above |
| Firefox iOS | `Fennec` | iOS | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Firefox iOS | `Fennec` | iOS | |
| Firefox iOS | `Fennec` | iOS | Uses Glean (see below) |

| Klar | `Klar` | Android | German Focus release |
| Firefox for Fire TV | `FirefoxForFireTV` | Android | |
| Firefox for Echo Show | `FirefoxConnect` | Android | |
| Firefox Lite | `Zerda` | Android | Formerly Rocket (See below) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the above use Glean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses Glean:

Firefox for Fire TV
Firefox for Echo Show
Lockwise Android (going away?)
Lockwise iOS (also going away?)
Firefox Reality for Android

Planning on integrating with Glean very soon:

Focus Android
Focus iOS
Klar? (discussion of whether or not to instrument Klar is in the works)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, there is also Reference Browser for Android that sends Glean telemetry.

Fire TV, Echo Show, Firefox Reality, and Firefox for iOS all send both core pings and Glean telemetry, and KPI reporting still relies on the core pings.

@jklukas
Copy link
Contributor

jklukas commented Oct 20, 2020

We now have a canonical UDF for "prettifying" app names, including a table of transformations in the docs. See https://mozilla.github.io/bigquery-etl/mozfun/norm/#product_info-udf

I think that table should probably be the source of truth documentation, since it's used to generate the UDF logic and is guaranteed to stay up to date. We should link to that table from these docs, and make sure our terminology is consistent between the two.

That said, the product_info table is currently mostly focused on making sure we have all the bases covered for mobile telemetry that feeds into KPIs. Currently, Fenix is the only app for which baseline pings are the source of truth we use for KPIs. We should definitely transition KPI reporting for Firefox iOS to baseline pings, but that has not happened yet.

So, I think it would be good for the docs here to list Glean apps for the time being, but defer to https://mozilla.github.io/bigquery-etl/mozfun/norm/#product_info-udf for naming. Then we should set a goal for January to fully codify in UDF form the mapping for Glean apps, and move to Glean as source of truth for KPIs wherever possible.

@tdsmith
Copy link
Contributor Author

tdsmith commented Oct 20, 2020

@jklukas do you know how to assign these datasets to release channels?

  org_mozilla_ios_fennec                 
  org_mozilla_ios_firefox                
  org_mozilla_ios_firefoxbeta

@tdsmith
Copy link
Contributor Author

tdsmith commented Oct 20, 2020

^ please disregard; Frank reminded me that the probe-info service can shed some light on these https://probeinfo.telemetry.mozilla.org/glean/repositories


Mobile data is structured differently when compared to desktop data. Instead of sending a `main` ping, mobile has provides the following key types of pings:
Legacy (pre-Glean) mobile data is structured differently than desktop data. Instead of sending a `main` ping, mobile has provides the following key types of pings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the info here on legacy event pings is incorrect. It's my understanding that events for mobile apps are sent in mobile-event and focus-event pings. The event ping is Desktop-specific.

@jklukas
Copy link
Contributor

jklukas commented Oct 21, 2020

I did not realize that https://probeinfo.telemetry.mozilla.org/glean/repositories contained logical channel names! This is great! We should absolutely be using this data as source of truth for building some downstream views. I'm going to write up an issue in bigquery-etl.

Edit: see mozilla/bigquery-etl#1466

@tdsmith tdsmith merged commit 7fd34b4 into master Oct 27, 2020
@tdsmith tdsmith deleted the fenix-buff branch October 27, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants