Bug 1215669 - Queue tab screenshots if BVC isn't visible #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebnich
force-pushed
the
background-thumbnails
branch
from
4722c81
to
fcef403
Compare
thebnich
force-pushed
the
background-thumbnails
branch
from
fcef403
to
295bd46
Compare
The ScreenshotHelper protocol is an abstraction artifact from when we needed to take screenshots from TabTrayController. Since we don't do this anymore, we can remove this layer of abstraction.
|
@jhugman Updated the PR. I moved the |
thebnich
added a commit
that referenced
this pull request
Nov 2, 2015
Bug 1215669 - Queue tab screenshots if BVC isn't visible
|
Landed fa0fd4e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue here is that
WKWebViewdoesn't render if its view controller isn't visible (presumably as an optimization). This fixes the problem by waiting until BVC is visible, then trying again.I spent awhile trying to figure out a good way to determine view controller visibility; in particular, I tried
self.navigationController?.visibleViewController === selfandisViewLoaded() && view.window != nil. Those mostly work, but I found I could trigger some edge casey false positives if the screenshotting fires during the tab tray -> BVC transition (these conditions all returntrue, yet the screenshot was still blank). I bit the bullet and tacked on aviewIsVisibleboolean that I just keep track of manually.